Skip to content

feat: Added Trimming/NativeAOT support.#21

Merged
joseharriaga merged 12 commits intoopenai:mainfrom
HavenDV:trimming
Jan 21, 2025
Merged

feat: Added Trimming/NativeAOT support.#21
joseharriaga merged 12 commits intoopenai:mainfrom
HavenDV:trimming

Conversation

@HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Jun 7, 2024 •
edited
Loading

Closes #20

But because preview version of System.Memory.Data does not explicitly support net6.0, this warning appears here

0>System.Text.Encodings.Web.targets(4,5): Warning  : System.Text.Encodings.Web 9.0.0-preview.4.24266.19 doesn't support net6.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
0>Microsoft.Bcl.AsyncInterfaces.targets(4,5): Warning  : Microsoft.Bcl.AsyncInterfaces 9.0.0-preview.4.24266.19 doesn't support net6.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
0>System.Text.Json.targets(4,5): Warning  : System.Text.Json 9.0.0-preview.4.24266.19 doesn't support net6.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
0>System.Memory.Data.targets(4,5): Warning  : System.Memory.Data 9.0.0-preview.4.24266.19 doesn't support net6.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.

There are two ways out:

  • Ignore, this can work without problems
  • Add #ifdef/ MSBuild Conditions to use old behavior for net6 and new for net8/netstandard

I'm waiting for feedback

@HavenDV HavenDV marked this pull request as ready for review June 7, 2024 07:40
KrzysztofCwalina
KrzysztofCwalina requested changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@KrzysztofCwalina KrzysztofCwalina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The core fixes look good! I just have a question and a change request I commented inline in the sources.

m-redding
m-redding reviewed Jun 7, 2024
View reviewed changes
m-redding
m-redding reviewed Jun 7, 2024
View reviewed changes
KrzysztofCwalina
KrzysztofCwalina reviewed Jun 10, 2024
View reviewed changes
@jcoc611-microsoft
Copy link

jcoc611-microsoft commented Nov 12, 2024

@HavenDV @KrzysztofCwalina any chance we could revive this PR and merge it in? would be super useful to get NAOT support (plus source generated JSON parsing would likely be more efficient than reflection)

@KrzysztofCwalina
Copy link
Collaborator

KrzysztofCwalina commented Nov 12, 2024

@HavenDV @KrzysztofCwalina any chance we could revive this PR and merge it in? would be super useful to get NAOT support (plus source generated JSON parsing would likely be more efficient than reflection)

Once you remove the trimming helper, I can unblock this PR.

@HavenDV
Merge branch 'refs/heads/main' into trimming
9004782 
# Conflicts:
#	OpenAI.sln
#	src/Custom/Common/InternalListHelpers.cs
#	src/Custom/OpenAIModelFactory.cs
#	src/OpenAI.csproj
@HavenDV
fix: Fixed issues.
cfe9902
@HavenDV
Copy link
Contributor Author

HavenDV commented Nov 15, 2024

@HavenDV @KrzysztofCwalina any chance we could revive this PR and merge it in? would be super useful to get NAOT support (plus source generated JSON parsing would likely be more efficient than reflection)

Once you remove the trimming helper, I can unblock this PR.

It has been removed

@HavenDV HavenDV changed the title feat: Added initial Trimming support. feat: Added Trimming support. Dec 2, 2024
@KrzysztofCwalina
Copy link
Collaborator

KrzysztofCwalina commented Dec 5, 2024

Thanks! Looks good!

@HavenDV HavenDV changed the title feat: Added Trimming support. feat: Added Trimming/NativeAOT support. Dec 5, 2024
@love-linger love-linger mentioned this pull request Dec 25, 2024
Closed
@heartacker
Copy link

heartacker commented Dec 25, 2024

anyothers approve.please

@joseharriaga
Copy link
Collaborator

joseharriaga commented Dec 26, 2024

Hello, @HavenDV ! We are working on a fix in our code generator that will take care of the file under the "src/Generated" folder. Current ETA is to have it merged soon after the holidays. Once that is in, we should be good to merge this PR too. I will keep you posted. Thank you!

@love-linger love-linger mentioned this pull request Jan 6, 2025
Closed
This was referenced Oct 13, 2025
Closed
Closed
Closed
Closed
Merged
This was referenced Oct 24, 2025
Merged
Merged
This was referenced Nov 12, 2025
Closed
Closed
This was referenced Nov 24, 2025
Merged
Closed
Open
This was referenced Dec 8, 2025
Closed
Closed
Closed
Closed
This was referenced Dec 22, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 29, 2025
Closed
Closed
Closed
Closed
Open
Closed
This was referenced Jan 5, 2026
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-redding m-redding m-redding left review comments

@KrzysztofCwalina KrzysztofCwalina KrzysztofCwalina approved these changes

@joseharriaga joseharriaga joseharriaga approved these changes

@trrwilson trrwilson Awaiting requested review from trrwilson

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja ShivangiReja is a code owner

+1 more reviewer

@stephentoub stephentoub stephentoub left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trimming/NativeAOT support

7 participants

@HavenDV @jcoc611-microsoft @KrzysztofCwalina @heartacker @joseharriaga @stephentoub @m-redding